Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/man: Fix installation directory #970

Merged
merged 1 commit into from
May 31, 2020
Merged

doc/man: Fix installation directory #970

merged 1 commit into from
May 31, 2020

Conversation

nmeum
Copy link
Contributor

@nmeum nmeum commented May 31, 2020

On Unix-like operating systems man pages are commonly installed to
/usr/share/man not /usr/share/stlink/man.


Also: I noticed the pkgconfig file is no longer installed by default, how do I fix that?

On Unix-like operating systems man pages are commonly installed to
`/usr/share/man` not `/usr/share/stlink/man`.
@nmeum
Copy link
Contributor Author

nmeum commented May 31, 2020

Also: I noticed the pkgconfig file is no longer installed by default, how do I fix that?

#add_subdirectory(cmake/pkgconfig)

🤔

@Nightwalker-87 Nightwalker-87 added this to the v1.6.2 milestone May 31, 2020
algitbot pushed a commit to alpinelinux/aports that referenced this pull request May 31, 2020
@Nightwalker-87
Copy link
Member

@nmeum: I currently don't see the need for it since these settings should be set by cmake's internal PkgConfig module. In fact this seems to be a leftover originally intended to be removed.

@nmeum
Copy link
Contributor Author

nmeum commented May 31, 2020

I currently don't see the need for it since these settings should be set by cmake's internal PkgConfig module.

The need for installing a pkgconfig file? Why even provide one in the first place then?

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented May 31, 2020

It was used up to the previous release, before the cmake package config was rewritten (that makes it a leftover from my point of view).

@nmeum
Copy link
Contributor Author

nmeum commented May 31, 2020

It was used up to the previous release, before the cmake package config was rewritten (that makes it a leftover from my point of view).

Well the cmake find_package package config thingy (cmake-packages(7)) and pkg-config are two entirely different things. The former can only be used with CMake, the latter also with other build systems (e.g. GNU make).

@Nightwalker-87
Copy link
Member

This thread should continue in the appropriate PR. Different topics should not be mixed.

@Nightwalker-87 Nightwalker-87 merged commit adb083c into stlink-org:develop May 31, 2020
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants